You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes an update to the default predicate value when evaluating guide activation url urls or patterns, where we now default to trueif given only url rules or patterns with a "block" directive. If there is at least one allow rule, then we maintain the current default value/behavior of false.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
thomaswhyyou
changed the title
default to true when evaluating only block url rules or patterns
feat: support for guide activation url rules or patterns with block directive
Nov 12, 2025
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.47%. Comparing base (be9ed36) to head (6729fc9). ⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thomaswhyyou
changed the title
Description
This PR makes an update to the default predicate value when evaluating guide activation url urls or patterns, where we now default to
trueif given only url rules or patterns with a "block" directive. If there is at least one allow rule, then we maintain the current default value/behavior offalse.Note, this PR is a requirement to supporting "exclusion" rules or patterns (as added in https://github.com/knocklabs/control/pull/6441 and https://github.com/knocklabs/control/pull/6442).
Screenshots or videos
CleanShot.2025-11-12.at.14.35.13.mp4